Hi, Generally I'm ok for such automatic tasks - we should test if the provided configuration for the IDE is completed and when we execute reformat code in the IDE we will have the same result.
śr., 12 paź 2022 o 18:51 Tamás Cservenák <[email protected]> napisał(a): > +1 for this. Tested on resolver, that has many old/untouched and hence, > badly formatted sources. > > T > > On Wed, Oct 12, 2022, 18:23 Guillaume Nodet <[email protected]> wrote: > > > I'd like to propose merging the following PRs: > > * https://github.com/apache/maven-shared-resources/pull/1 > > * https://github.com/apache/maven-site/pull/329 > > * https://github.com/apache/maven/pull/824 > > * https://github.com/apache/maven-resolver/pull/147 > > ... and more to come > > > > The idea is to use plugins to automatically reformat the source code and > > sort imports to obey the maven coding style. > > The first PR adds the necessary resources to maven-shared-resources : a > new > > header file, as there's a requirement to put the header at the very > > beginning for the import sorter plugin to work correctly (else it > considers > > the license comment to be part of comment headers and screws the > > formatting), and the eclipse xml formatter plugin. > > The second PR updates the web site to point to that file which would be > in > > git instead of on the maven web site, and also updates the instruction > for > > IDEA since it has been supporting the eclipse xml config for years now). > > The third and fourth PRs are updates on maven and maven-resolver to apply > > those two plugins. > > > > Those plugins have been used on mvnd and maven-build-cache-extension > > already, although they are not using a single shared resource that would > be > > added by the first PR. Hence mvnd is still using its previous coding > > style. > > > > Another point is that those plugins are fast and only do not process > files > > if they have been already processed and untouched since the last build. > So > > from a daily development pov, this is transparent and does not incur any > > additional processing time during the build (or not much really). > > > > Cheers, > > Guillaume > > > -- Sławomir Jaranowski
