Big +1
I sometimes need to switch back from JDK 21 to 17 or earlier to build
some of the plugins.
If we start building with 11+, we can detect build errors easier for newer JDKs.
The spotless profile might not be the only profile we can remove.
One catch, though. Should we not test on JDK8? Maybe on toolchains?
But I (personally) think from my experience the risk is very low.
I have been building all my Java 8 apps with 11 for years, and now I
am building Java 17 apps with 21 and never had a problem.
On the contrary, build times went down by an insane amount, up to 50%
less build time! :)
Of course, YMMV. If there are technical reasons preventing this... so be it.
But even then I would like to seek solutions first.
- Ben
Am Mo., 13. Nov. 2023 um 20:38 Uhr schrieb Karl Heinz Marbaise
<khmarba...@gmx.de>:
>
> Hi,
>
> currently we have already the build requirements for Maven Core at JDK11+
>
> So in consequence I would suggest to lift the minimum requirement for
> building plugins to JDK11.
>
> That means also we can use "--release 8" option
> (<maven.compiler.release>8</maven.compiler.release>) instead of
> source/target which is not correct based on the warnings we get like:
> "[WARNING] bootstrap class path not set in conjunction with -source 8"
> which we get in all plugins based on the configuration in maven parent
> using this:
>
> <javaVersion>8</javaVersion>
> <maven.compiler.source>1.${javaVersion}</maven.compiler.source>
> <maven.compiler.target>1.${javaVersion}</maven.compiler.target>
>
> which is not correct because we don't use animalsniffer anymore.
>
> So my suggestion is to lift the JDK build requirements to JDK11...
> and use the <maven.compiler.release>8</maven.compiler.release> which
> will prevent the warning. Also brings us back the safety net which
> animal-sniffer was before.
>
>
> Later on version of maven-parent (v42?) should change the whole
> configuration (there are some related parts like maven-pmd-plugin,
> maven-enforcer-plugin (enforce-byte-code max)..also toolchain-plugin...
>
> Furthermore we could get rid of the profile for JDK11+ related to
> spotless-maven-plugin ...
>
> Based on the upgrade to maven-parent v41 we could also enhance the build
> pipelines to build on JDK21
>
> WDYT?
>
> Kind regards
> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
