----- Original Message -----
From: "Brett Porter" <[EMAIL PROTECTED]>
To: "Maven Developers List" <[EMAIL PROTECTED]>
Sent: Friday, July 02, 2004 2:33 AM
Subject: Re: cvs commit: maven/src/java/org/apache/maven/plugin
PluginManager.java
> Emmanuel,
>
> This is checking the wrong directory - the user plugin directory is
usually
> empty (ie jars in $MAVEN_HOME_LOCAL/plugins). It should be checking the
first
> one: pluginFiles. (that is $MAVEN_HOME/plugins)
>
> Also, wouldn't userPluginFiles.isEmpty() be much easier? :)
Done.
>
> - Brett
>
> > Map pluginFiles = getPluginFiles( pluginsDir, true );
> > - pluginFiles.putAll( getPluginFiles( userPluginsDir,
false ) );
> > + Map userPluginFiles = getPluginFiles( userPluginsDir,
false );
> > +
> > + if ( !Collections.EMPTY_MAP.equals( userPluginFiles ) &&
> > + Collections.EMPTY_MAP.hashCode() ==
userPluginFiles.hashCode()
> > )
> > + {
> > + pluginFiles.putAll( userPluginFiles );
> > + }
> > + else
> > + {
> > + throw new MavenException( "Maven was badly installed.
Please
> > reinstall it." );
> > + }
> > +
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
