The following comment has been added to this issue:
Author: Felipe Leme
Created: Thu, 15 Jul 2004 8:54 AM
Body:
> Thanks for the patch. Here are some comments/questions:
Thank you for the quick reply - patches/bug reports to popular projects like Maven
usually take longer to be answered :-)
> 1/ I'm interested to know why you need to provide your own stylesheet.
We use a different format for our email announcement (by the way, we're also working
in a patch that sends the announcement by mail - I will submit it under
MPANNOUNCEMENT-9 once it's ready). Besides being in a different language (Portuguese),
we need more info, like:
- SCM tag used for the release
- id of the last snapshot
- more URLS (documentation, downloads, etc...)
Of course, we could just change the content of anouncement.jcl, but that is not an
elegant solution - what if I need 2 different templates, for instance? (In fact, we
will face that situation in the future, as some of our components will be distributed
internally and externally).
> Is there anything missing in the existing that we could add?
Yes, we have those specific needs mentioned before. And other organizations might have
different ones, so we better provide a configurable template than trying to include
everything ourselves.
> How are you using the new properties you've set?
Right now, we are setting the value property globally (i.e., in the multiproject root)
and using the default value of 'resource' (the reason for this option is that we are
using our customized version of maven, so the new announcement file get automatically
installed at $MAVEN_REPO)
> 2/ I don't think there's a need for the stylesheet "Type". Simply
> define the location and you're done.
I think the type make it more flexible. For instance, in our case we are using the
resource, as we are installing a customized version of the plugin. Most of the time,
though, I think people could use 'uri' for a global/generic announcement (defined at
multiproject level, for instance) and 'project' for a project specific one.
> 3/ Yes, there should be unit tests. We need to add tests. Have a
> look at some other plugins like checkstyle, changes, etc. Check in
> src/plugin-test. Tests are run by calling "maven plugin:test".
Ok, I will take a look on them and write the tests later (once we decided how the new
feature will be implemented, for instance, having the type property or not).
Regards,
Felipe
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPANNOUNCEMENT-11?page=comments#action_21813
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANNOUNCEMENT-11
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANNOUNCEMENT-11
Summary: [PATCH] Option to set different templates to be used as announcement
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: 15 minutes
Time Spent: Unknown
Remaining: 15 minutes
Project: maven-announcement-plugin
Assignee:
Reporter: Felipe Leme
Created: Tue, 13 Jul 2004 1:54 PM
Updated: Thu, 15 Jul 2004 8:54 AM
Environment: maven-plugins from CVS main branch
Description:
Hi Vince,
It would be nice to allow using different templates (i.e., stylesheet) for the
announcement file.
I did some changes (not sure if they're the best, as Jelly is very tricky :-) at
plugin.jelly, so now it looks for the following properties in order to define the
stylesheet:
maven.announcement.stylesheet.locationType
maven.announcement.stylesheet.locationValue
locationType determines the context where the stylesheet is located (right now:
resource, uri or project) and locationValue is the path per see - I'm describing the
process in more details on xdocs/properties.xml.
So, I'm sending a patch created from the CVS branch (I've set the currentVersion as
1.3-SNAPSHOT in the project.xml and xdocs/changes.xml included in the patch)
Regards,
Felipe (felipeal at ASF)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
