The following comment has been added to this issue:
Author: Vincent Massol
Created: Thu, 15 Jul 2004 1:07 PM
Body:
> The only problem I see with a full path is that it would require
> knowing the physical location of the file or some sort of EL hack
> to obtain it (ex: path=${basedir}/etc/myAnnouncements.jsl). I
> agree that adding a type increases the complexity, but I still
> think that option is usefull. What if we keep the Type, but set it
> as 'uri' by default?
How is the following a problem?
Custom (user overriden):
path = ${basedir}/conf/myannouncement.jsl
Default:
path = ${plugin.resources}/announcement.jsl
Using a type property is much worse IMO as it will only permit the locations that are
hard-coded in the script which is limitating, more complex and simply unnecessary.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPANNOUNCEMENT-11?page=comments#action_21834
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANNOUNCEMENT-11
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANNOUNCEMENT-11
Summary: [PATCH] Option to set different templates to be used as announcement
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: 15 minutes
Time Spent: Unknown
Remaining: 15 minutes
Project: maven-announcement-plugin
Assignee:
Reporter: Felipe Leme
Created: Tue, 13 Jul 2004 1:54 PM
Updated: Thu, 15 Jul 2004 1:07 PM
Environment: maven-plugins from CVS main branch
Description:
Hi Vince,
It would be nice to allow using different templates (i.e., stylesheet) for the
announcement file.
I did some changes (not sure if they're the best, as Jelly is very tricky :-) at
plugin.jelly, so now it looks for the following properties in order to define the
stylesheet:
maven.announcement.stylesheet.locationType
maven.announcement.stylesheet.locationValue
locationType determines the context where the stylesheet is located (right now:
resource, uri or project) and locationValue is the path per see - I'm describing the
process in more details on xdocs/properties.xml.
So, I'm sending a patch created from the CVS branch (I've set the currentVersion as
1.3-SNAPSHOT in the project.xml and xdocs/changes.xml included in the patch)
Regards,
Felipe (felipeal at ASF)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
