I'd think the preferred approach is to use resources for including files in the jar. If this is not working correctly and consistently, let's work to fix it.
This works fine. The only inconsistency is that LICENSE.txt is included automatically by the jar plugin, but the ant plugin does not generate code to include it.
The other issue is the files added to top-level directories of the tarballs by the dist plugin. Now this is hard-coded. It would be convenient to be able to specify other / additional files to include somehow.
Phil
On Sun, 16 Jan 2005 08:58:19 -0500, Phil Steitz <[EMAIL PROTECTED]> wrote:
Apache distributions need to include LICENSE.txt and NOTICE.txt in top-level directories as well as in jar META-INF directories. Other notices may be required as well (e.g., INCUBATOR-DISCLAIMER.txt, README.txt). The jar plugin handles LICENSE.txt, but not NOTICE.txt; the dist plugin handles both; the ant plugin handles neither. The end result is that we need to use resource elements to get files other than LICENSE.txt in to maven-generated jars, script to get INCUBATOR-DISCLAIMER.txt and other notices into the distributions, and we can't generate build.xml files that insert LICENSE.txt without getting duplicate copies of this file in maven-generated jars (since you need to add it as a resource to get the ant plugin to add it).
I submitted a patch (MPANT-23) to get the ant plugin to include LICENSE.txt, but am now thinking that in all of these cases it might be better to have these files specified in properties, defaulting to current behavior. I tried to do this in a patch attached to MPDIST-20. If others think that this is a good approach, I can submit patches to the other plugins. WDYT?
Phil
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
