Hi Brett, > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: vendredi 23 septembre 2005 09:04 > To: [EMAIL PROTECTED] > Subject: svn commit: r291085 - /maven/components/trunk/maven- > plugins/maven-clover- > plugin/src/main/java/org/apache/maven/plugin/clover/CloverReportMojo.java
[snip] > goal naming consistency [snip] > * @author <a href="mailto:[EMAIL PROTECTED]">Vincent Massol</a> > * @version $Id$ > - * @goal report > + * @goal clover > * @execute phase="test" lifecycle="clover" > */ > public class CloverReportMojo extends AbstractMavenReport Could you please explain the rationale for this? I'm quite strongly against it unless there is a very good reason which I don't see ATM (I don't consider the fact that other plugins do it a good enough reason - I think they are also wrong ;-)). The reasons I don't like it: - The name clover for a goal doesn't mean anything. "clover:report" is much better than "clover:clover" for understanding what the goal does. - I don't think the report goal should be more important than another one in the Clover plugin. There are different goals that do different things (clover:check, clover:report, etc). I would be ok (even though I don't like particularly like it) to create another Mojo mapped to the clover goal and that would delegate to the clover:report. I think your motivation comes from the fact that there is a clover:clover goal in m1, right? Of course I would even prefer a goal aliasing mechanism or a new default goal javadoc parameter (@default-goal) to specify a default plugin goal when it makes sense. This goal could be called when [plugin name]:[plugin name] is called and if none are defined an error saying that the plugin has no default goal would be displayed, possibly listing all the available goals. Thanks -Vincent --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
