[ http://jira.codehaus.org/browse/MNG-1113?page=all ]

Mark Kuzmycz updated MNG-1113:
------------------------------

    Attachment: recommended.txt

I would prefer the supplied file. The propertyFile is meant for property 
expansions. If we overload the field then you cannoy use property expansions 
and a custom format.

Also, I have made a small change to the property load to close the stream. 
Without it you leave the file open (it is good practice to clean up ;) ).

> Plugin does not support using custom checkstyle XML config file
> ---------------------------------------------------------------
>
>          Key: MNG-1113
>          URL: http://jira.codehaus.org/browse/MNG-1113
>      Project: Maven 2
>         Type: Bug
>   Components: maven-checkstyle-plugin
>     Versions: 2.0-beta-3
>     Reporter: Vincent Massol
>     Assignee: Edwin Punzalan
>  Attachments: MNG-1113-maven-checkstyle-plugin.patch, recommended.txt
>
>
> The plugin source code says:
>     /**
>      * Specifies the location of the checkstyle properties that will be used 
> to check the source.
>      *
>      * @parameter
>      */
>     private File propertiesFile;
> But in practice it's only loading *properties* and not the XML. The 
> getConfigFile() method is not right and needs to be modified to take into 
> account a custom checkstyle config file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to