dan tran a écrit :


On 11/18/05, *Wim Deblauwe* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote:



    2005/11/18, Emmanuel Venisse <[EMAIL PROTECTED]
    <mailto:[EMAIL PROTECTED]>>:



        Wim Deblauwe a écrit :
 So, summarizing:

 1) we need a lock/edit command in the ScmProvider interface,
        since the
 release plugin knows that interface. We then have 2 options:
        define a
 special property or let the release plugin call lock/edit
        always and
 provide an empty implementation in AbstractScmProvider for the
 non-clearcase SCM's. For me option 2, seems nicest.

        We need these 2 options. Default implementation will do nothing
        for providers that don't have a
        specific implementation. The special property will be useful for
        some provider like cvs. In cvs, we
        can have 2 modes (with or without lock/edit), so we'll implement
        the lock/edit command in cvs and
        users can activate or not it with the special property. Release
        plugin can't always call lock/edit
command, it will depend on users configuration.

    ok, so I'll go ahead and add 2 methods (edit and unedit) to the
    ScmProvider interface. But how should I implement them in
    AbstractScmProvider currently? Leave them empty or throw exception?
If I understand correctly, you are going to define 2 new interfaces edit and unedit. however maven-scm already have lock and unlock which are the equivalent

we rename lock/unlock to edit/unedit that is more common.



 2) checkout is currently incorrectly implemented. It currently
        calls
 'cleartool co', but it should not do that. It should create a
        view
 dynamically (not impossible), but then? Should it copy the
        contents to
 some file location? But then you won't be able to do any
        clearcase
 operations on that.

        You're our clearcase specialist (With Dan), so implement it like
        you think it's better. Personnaly,
        i think it isn't a good idea to copy contents to an other
        location if we can't do other operations
        of them


    Is this needed by continuum only? Or what tools/plugins might need
    this also? Isn't it possible to just point to a local file in
    continuum and tell continuum to build that on the location it is.
    Because for clearcase, a lot of parameters are needed and it will
    not be that easy.
    The most important for me right now is getting the release plugin to
    work, so I would like to change the current checkout implementation
    to throw an exception for clearcase (in stead of doing the wrong
thing as it does currently). I will help with the checkout command once we understand most common usecases. Agree now that you can focus on getting release plugin to work. It is your call to throw except in
checkout command.
One of my experience learning from maven scm folks is write junit test cases will help a lot during integration with other maven plugin and continuum. Starteam was a big surprise for me since it integrates seemlessly. Special thanks you for leading this effort with clearcase implementation, i am sure other users will
jump in once this is started.

yes, thanks. I'm sure too.

Emmanuel

Reply via email to