I don't quite get it, are you talking about the method
ConfigurationValidationResult validateConfiguration( Configuration
configuration )
in the embedder?
I changed it to store the settings (if there is no error) and the
exception (if there is). Before there was no way to know what the
problem with the settings was.
Couple of comments about the other changes made:
* ConfigurationValidationResult
changed Throwable to Exception, although in other places like
MavenExecutionResult Throwable is being used
* setters in interfaces
Do we really want setters in the interfaces (MavenExecutionRequest,
MavenExecutionResult,...). I don't think they should be there, only in
the implementations.
On 9/1/07, Jason van Zyl <[EMAIL PROTECTED]> wrote:
> Carlos,
>
> Please put back the validation methods. I don't want to catch
> exception to validation user configuration. I want to be able to know
> exactly what's wrong. I don't need to throw an exception to find out
> the specific settings are not present and I'm using all these methods
> extensively.
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder and PMC Chair, Apache Maven
> jason at sonatype dot com
> ----------------------------------------------------------
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
