On 5 Sep 07, at 4:01 PM 5 Sep 07, Carlos Sanchez wrote:



You can do
DefaultMavenExecutionRequest request = new
DefaultMavenExecutionRequest();
request.setBaseDirectory( baseDirectory );
request.Goals( goals );

and then pass it around as MavenExecutionRequest. The fact that they
are needed to create an instance doesn't mean that they are needed in
the interface, it should be used to query for information, not to
provide it.


I have already in cases because of coupling, required setting something beyond the requests instantiation. This optimally should not be the case but isn't the case right now.

If for instance you want another implementation of the
MavenExecutionRequest with some default values or one that will query
other objects for them you are forcing the implementation to have
empty setters.

Do you actually have one? All the use I've seen takes the request object and populates it according to their needs.

I'll answer the other questions in another thread.

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to