the point of the tests is not to prove to me that there is a problem, it's to help us safeguard against reintroducing that problem later. If I have a ready-made test that I can incorporate, it'll save me a lot of time and make it more likely that I'll be able to get your fix in.
-john On Jan 30, 2008 3:24 PM, Sejal Patel <[EMAIL PROTECTED]> wrote: > I've updated 277 with a patch. Not sure that you really need proof to see > that a chunk of code that says "project.getBaseDir()" followed by a "if > (project == null)" is a bad thing that should be reversed. > > issue 278 I can provide the patch but i think there is confusion since > there > was a proposed solution for how it should work but that solution doesn't > work which is why i was asking for this fix. i'll go ahead and whip up the > patch and attach it soon though. > > On Jan 30, 2008 2:49 PM, John Casey <[EMAIL PROTECTED]> wrote: > > > Patches would be a big help, particularly if they include tests that > > exhibit the failure behavior, as this can take some time to replicate > > (even if they are small fixes, you're familiar with the problem, > > while I'm not). > > > > Thanks, > > > > -john > > > > On Jan 30, 2008, at 12:04 PM, Sejal Patel wrote: > > > > > My suggestion is before releasing 2.2-beta-2, that the following > > > issues be > > > addressed (simple 1 liner fixes) > > > > > > http://jira.codehaus.org/browse/MASSEMBLY-277 (null pointer exception) > > > http://jira.codehaus.org/browse/MASSEMBLY-278 (config to not fail > > > out on > > > missing descriptor) > > > > > > If you like, I can even give you the actual patch to do these in > > > about 5 > > > minutes time as well. > > > > > > > > > On Jan 30, 2008 9:32 AM, Paul Gier <[EMAIL PROTECTED]> wrote: > > > > > >> Hey Everyone, > > >> I noticed that the assembly plugin has not been released in a > > >> while (since > > >> last > > >> april) and it seems like there are a lot of useful fixes in the > > >> current > > >> trunk. > > >> > > >> I also noticed some issues that can probably be resolved easily: > > >> http://jira.codehaus.org/browse/MASSEMBLY-188 (this is a duplicate) > > >> http://jira.codehaus.org/browse/MASSEMBLY-189 (has a working patch > > >> and > > >> test and > > >> several votes) > > >> http://jira.codehaus.org/browse/MASSEMBLY-182 (minor site updates) > > >> http://jira.codehaus.org/browse/MASSEMBLY-274 (my issue that I'd > > >> like to > > >> see > > >> fixed ;) > > >> > > >> What other tasks remain before 2.2-beta-2 can be released? Can > > >> some of > > >> the > > >> current scheduled 2.2-beta-2 issues be pushed to a beta-3 if they > > >> are more > > >> difficult? > > >> > > >> Thanks! > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > > >> For additional commands, e-mail: [EMAIL PROTECTED] > > >> > > >> > > > > > > > > > -- > > > Justice is nothing more than that which is in the greatest self- > > > interest of > > > the largest portion of the population. > > > > --- > > John Casey > > Committer and PMC Member, Apache Maven > > mail: jdcasey at commonjava dot org > > blog: http://www.ejlife.net/blogs/john > > rss: http://feeds.feedburner.com/ejlife/john > > > > > > > > > -- > Justice is nothing more than that which is in the greatest self-interest > of > the largest portion of the population. > -- John Casey --- Maven Developer (http://maven.apache.org) --- Blog: http://www.ejlife.net/blogs/buildchimp
