I've encountered this in the IDE integration for netbeans when I want
to allow users to set encoding for the project. Currently I'm setting
configuration for compiler-plugin and resources-plugin but that's
cumbersome.


On Wed, Mar 26, 2008 at 11:37 AM, Benjamin Bentmann
<[EMAIL PROTECTED]> wrote:
> > There is one feature in this patch I don't like: you hardcoded a default
>  > encoding to ISO-8859-1 instead of no default value (which means platform
>  > encoding).
>
>  Indeed, I also suggested using a fixed default value for other plugins:
>  - MCOMPILER-63
>  - MJAVADOC-165
>  - MRESOURCES-57
>
>  I simply chose Latin-1 here to be consistent with the Site Plugin whose
>  inputEncoding/outputEncoding likewise defaults to Latin-1 for quite some
>  time.
>
>
>  > even if a developer wanted to configure platform encoding, he could not!
>
>  Something like
>   <encoding>${file.encoding}</encoding>
>  should still do, wouldn't it?

adding elements to pom.xml would be incompatible change however and
will take a long time to get in production.. What about just unifying
the expressions that refer to encoding in plugins?
javadoc-plugin has ${encoding}
compiler-plugin has ${maven.compiler.encoding}
resources-plugin has no expression defined.

If all places defined a common name, we would be fine, right? you
would just define the right property in the pom..

Regards


Milos

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to