On 3-May-08, at 3:34 AM, Hervé BOUTEMY wrote:
The change is only on version comparison, not version parsing to
dispatch info
to ArtifactVersion API, which would have probably more impact.
This still could potentially impact users.
Just for the record I think Kenney's proposal is good, sound, and more
correct then what we have but we still can't change the behavior in
2.0.x. I think what you're doing is the right way to go but we
definitely need more tests, and I'm still afraid of putting it in the
branch because it's so quirky. Even so the behavior has to be preserved.
AFAIK, version comparison is used only for version ranges, but I
don't know
every aspect of Maven to be sure of this.
As asked by Jason, I'll try integration tests and report before doing
anything, either on trunk or branch.
I'm honestly more concerned about the branch. Integration tests are
good overall but if they reveal errors we can keep track of that and
allow the quirks to be emulated on trunk if necessary.
Hervé
Le vendredi 02 mai 2008, Brian E. Fox a écrit :
What's the impact to existing builds. My initial reaction is no-way
in
2.0.x.
-----Original Message-----
From: Hervé BOUTEMY [mailto:[EMAIL PROTECTED]
Sent: Thursday, May 01, 2008 4:07 PM
To: Maven Developers List
Subject: Artifact Version Comparison
Kenney started a proposal http://docs.codehaus.org/display/MAVEN/Versioning
with a implementation of a comparator.
I took his implementation, updated it to support comparison between
more
version schemes and integrated it to DefaultArtifactVersion class.
The code
is here http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/
,
with unit test showing version schemes in action:
http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/src/test/java
/org/apache/maven/artifact/versioning/ComparableVersionTest.java
I think the new ordering will give better results than the current
one and
would like to merge it to artifact trunk and 2.0.x branch. Before
doing so,
I submit the code for review: any comments?
regards,
Hervé
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
To do two things at once is to do neither.
-—Publilius Syrus, Roman slave, first century B.C.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
