So the change was just to allow numerical ordering for non-standard
versions like alpha-1 vs alpha-11 and 5.0.9.0 vs 5.0.10.0 ?
That looks ok to me at first glance, but I'll take a closer look.
- Brett
On 16/05/2008, at 5:02 AM, Hervé BOUTEMY wrote:
FYI, I just merged version comparison improvement to artifact trunk.
2.1.x ITs are ok, both on my machine and on Sonatype's CI server
I hope everything is ok for everybody
Don't hesitate to ring me if anything goes wrong
regards,
Hervé
Le jeudi 01 mai 2008, Hervé BOUTEMY a écrit :
Kenney started a proposal http://docs.codehaus.org/display/MAVEN/Versioning
with a implementation of a comparator.
I took his implementation, updated it to support comparison between
more
version schemes and integrated it to DefaultArtifactVersion class.
The code
is here http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/
,
with unit test showing version schemes in action:
http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/src/test/java
/org/apache/maven/artifact/versioning/ComparableVersionTest.java
I think the new ordering will give better results than the current
one and
would like to merge it to artifact trunk and 2.0.x branch. Before
doing so,
I submit the code for review: any comments?
regards,
Hervé
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
