I agree with Dennis, though if any reordering is to be done I think the order proposed by Vincent makes sense.

I agree with Jesse and Paul about adding goals to the POM plugin to help adjust POMs.

Cheers,
Brett

On 26/06/2008, at 1:29 AM, Jesse McConnell wrote:

+1, great idea

Not sure it was mentioned before or not but would also be nice to have
something like help:reformat goal for juggling things around in the
pom to the correct format.  Maybe it would be more appropriate to
clean up and finish off some of the things I had worked on with the
pom plugin in the sandbox and add this as a mojo in there.
pom:reformat would be pretty nice

cheers
jesse

On Wed, Jun 25, 2008 at 10:20 AM, Dennis Lundberg <[EMAIL PROTECTED]> wrote:
Benjamin Bentmann wrote:

Vincent Siveton schrieb:

I propose to improve [1] to add a code style for our pom files.

+1 for some convention (which is documented as such).

Yep, +1 for a POM code style

I see the following in this order.

Considering other POMs like parent POMs and Mojo, your proposal should
finally cover all POM elements (e.g. <packaging>, <url>, <licenses>,
<developers> etc.).

Whatever we agree upon, we might want to update the Maven Model Reference
[0], too. I guess that was the ordering Dennis has chosen.

I've always followed the ordering that is in the Model Reference.

I don't have a special preference for which order the elements should be in and I'm happy with what we have now. If we change the order of the elements in the POM, then there will be a lot of POMs to change. So I say we apply the path of least resistance and just document that our "style" is that POM elements should be ordered according to the order they have in the POM
reference and be done with it.


If not already written down, the indentation style (2 spaces) should be
mentioned, too.

+1 for that too

Additional things we could add:

- Line breaks, when to use them and how
- <project> element always on one line
- white space between sections/elements

<project>
...
</project>

I find your proposed ordering more intuitive than the current Model Ref.


Benjamin


[0] http://maven.apache.org/ref/current/maven-model/maven.html

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
jesse mcconnell
[EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to