On 15/07/2008, at 8:32 PM, Mark Hobson wrote:
I've noticed that dependency reduced pom produced by the shade plugin
contains unnecessary exclusions. Checking the code, in ShadeMojo:825
we have:
//anything two levels deep that is not marked
"included"
//is stuff that was excluded by the original poms,
make sure it
//remains excluded
if ( n3.getState() == DependencyNode.INCLUDED)
The comment sounds right to me which contradicts the code. Anyone
disagree with negating the logic?
It sounds right to me, as long as there is some test to exercise it.
Since this is quite a major bug, can we push out a 1.1.1 release with
this fix? The only work that's occurred on trunk since 1.1 is
MSHADE-35.
I think it's worth getting a release out regardless, yes.
- Brett
--
Brett Porter
[EMAIL PROTECTED]
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
