On 17/12/2008, at 11:03 AM, Oleg Gusakov wrote:
Brett,
Please don't change the code you don't understand without, at least,
consulting people who work on it.
I did try... http://markmail.org/message/ifkbjf3rb24z3wvb
I have a good understanding of how the code works. Outside of the
Jetty client, I think I may be the only person (with the possible
exception of Jason) that has given it a decent look over at this
point. I'm still seeking you're enlightenment on the pieces I didn't
understand: http://markmail.org/message/tibxv4f7di2caj2y, and am still
looking forward to your response.
I lost entire day between yesterday and today, trying to understand
why my unit tests suddenly stopped working. They traced to your
commit r725533 which emptied jar files in mercury-ant-tasks! Unit
tests were using those jars to compile test code.
I'm sorry you lost some time investigating it, but I made every
attempt to do this properly.
At the time I made the change, I cleaned out the checkout and did a
build without getting any test errors. This was confirmed by the grid: https://grid.sonatype.org/ci/view/Mercury/job/mercury-ant/6/
It appears your change to test using compilation was only checked in
afterwards. I'm afraid I'm still working on my ability to predict the
future :)
Certainly if it had been a functional change I'd have spent more time
in consultation as you suggested. The example you gave from Benjamin
is certainly a good way for things to work. We all need to tread
lightly in unfamiliar territory, and I understand that. I have no
desire to look like an idiot through inexperience if I can avoid it.
Anyway, thanks for fixing up the size of the test repo even in the
"reversion". I do appreciate it.
- Brett
--
Brett Porter
br...@apache.org
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
