Yes, IF the xwiki build works without that code in place. I guess I'll fire up that build today to see.

Benjamin Bentmann wrote:
nicolas de loof wrote:

------------------------------------------------------------------------
r616830 | jdcasey | 2008-01-30 19:24:41 +0100 (mer., 30 janv. 2008) | 1 line

porting revId 616610 of trunk back to 2.0.x branch

The commits mentioned suggest that your analysis was right and the code in the 2.x branches is buggy. While in the original r616610 the return value of normalizeToArtifactRepositories() is used, it's not in r616830 and the method has no side effects either.

This naturally leads to the question, if the code in 2.x isn't effective anyway and nothing requires it in practice, should we should get rid of it?


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to