Benjamin Bentmann wrote:
Hi Paul,
Author: pgier
Date: Fri May 15 16:16:59 2009
New Revision: 775216
URL: http://svn.apache.org/viewvc?rev=775216&view=rev
Log:
Add configuration for creating the src dist files during a realease.
Added:
maven/ant-tasks/branches/maven-ant-tasks-2.0.x/src/assembly/
maven/ant-tasks/branches/maven-ant-tasks-2.0.x/src/assembly/src.xml
(with props)
Modified:
maven/ant-tasks/branches/maven-ant-tasks-2.0.x/pom.xml
Added:
maven/ant-tasks/branches/maven-ant-tasks-2.0.x/src/assembly/src.xml
URL:
http://svn.apache.org/viewvc/maven/ant-tasks/branches/maven-ant-tasks-2.0.x/src/assembly/src.xml?rev=775216&view=auto
==============================================================================
---
maven/ant-tasks/branches/maven-ant-tasks-2.0.x/src/assembly/src.xml
(added)
+++
maven/ant-tasks/branches/maven-ant-tasks-2.0.x/src/assembly/src.xml
Fri May 15 16:16:59 2009
@@ -0,0 +1,29 @@
+<assembly>
+ <id>src</id>
+ <formats>
+ <format>tar.gz</format>
+ <format>zip</format>
+ </formats>
+ <includeBaseDirectory>false</includeBaseDirectory>
+ <fileSets>
+ <fileSet>
+ <directory>${project.basedir}</directory>
+ <outputDirectory>/</outputDirectory>
+ <useDefaultExcludes>true</useDefaultExcludes>
+ <excludes>
+ <exclude>target/**</exclude>
+ <exclude>*~</exclude>
+ <exclude>*.log</exclude>
+ <exclude>.classpath</exclude>
+ <exclude>.project</exclude>
+ <exclude>.settings/**</exclude>
+ <exclude>*.ipr</exclude>
+ <exclude>*.iws</exclude>
+ <exclude>*.iml</exclude>
+ <exclude>.wtpmodules</exclude>
+ <exclude>target-eclipse/**</exclude>
+ <exclude>bin/**</exclude>
+ </excludes>
+ </fileSet>
+ </fileSets>
+</assembly>
This descriptor heavily relies on exclusions for the proper contents. If
somebody has files in the project base directory that you didn't
anticipate, the source bundle gets spoiled. I believe using includes is
safer and easier to maintain, i.e. include "${basedir}/src" and the few
others files from the base directory like the predefined src descriptor
of the Assembly Plugin does.
The resulting source bundle seems to miss LICENSE and NOTICE files.
The directory structure of source bundle does not root in a directory
named after the bundle, i.e.
maven-ant-tasks-2.0.10/
src/
No biggie yet something that should be synced up with the format
required/expected by ASF. Brian is probably the best to tell what's
required, I only noticed the bundle differs from the last source bundle
for Maven 2.1.0-M1 [1].
Also, what archive formats are we expected to create? The predefined src
descriptor produces zip, tar.gz and tar.bz2. In contrast the
hand-written descriptor for the Ant Tasks misses tar.bz2.
Sorry that I can't provide answers to these by myself, just wanted to
save you from another release that might be cancelled.
Benjamin
[0]
http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html#src
[1] http://apache.org/dist/maven/source/apache-maven-2.1.0-M1-src.zip
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Ok, it's fixed. Thanks for the suggestions! Brian are the requirements for the
source distribution defined somewhere? So I can make sure I'm not missing
anything?
Thanks!
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
