Paul Gier wrote:

Staging repo:
https://repository.apache.org/content/repositories/maven-013/

-1

The implementation for MANTRUN-100 has two flaws:

  if ( classifier == null )
  {
    mavenProject.setFile( file );
  }
  else
  {
    ArtifactHandler handler = new DefaultArtifactHandler( type );
Artifact artifact = new AttachedArtifact(mavenProject.getArtifact(), type, classifier, handler);
    artifact.setFile( file );
    artifact.setResolved( true );
log( "Attaching " + file + " as an attached artifact", Project.MSG_VERBOSE );
    mavenProject.addAttachedArtifact( artifact );
  }

a)
mavenProject.setFile( file ) sets the path to the POM, not the main artifact.

b)
DefaultArtifactHandler and AttachedArtifact are internal implementation classes, the code should use MavenProjectHelper and interfaces instead.


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to