Benjamin Bentmann wrote: > Paul Gier wrote: > >> Staging repo: >> https://repository.apache.org/content/repositories/maven-013/ > > -1 > > The implementation for MANTRUN-100 has two flaws: > > if ( classifier == null ) > { > mavenProject.setFile( file ); > } > else > { > ArtifactHandler handler = new DefaultArtifactHandler( type ); > Artifact artifact = new AttachedArtifact(mavenProject.getArtifact(), > type, classifier, handler); > artifact.setFile( file ); > artifact.setResolved( true ); > log( "Attaching " + file + " as an attached artifact", > Project.MSG_VERBOSE ); > mavenProject.addAttachedArtifact( artifact ); > } > > a) > mavenProject.setFile( file ) sets the path to the POM, not the main > artifact. > > b) > DefaultArtifactHandler and AttachedArtifact are internal implementation > classes, the code should use MavenProjectHelper and interfaces instead. > > > Benjamin > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org >
Hi Benjamin, Thanks for the feedback and thanks for fixing MANTRUN-139. I have fixed a) and b) according to your suggestions, and recreated the release. The new staging repository is https://repository.apache.org/content/repositories/maven-014/ Regarding DefaultArtifactHandler vs. MavenProjectHelper, I was trying to find a way that the task could be dependent only on the Maven project since the task does not have direct access to the Maven components. Maybe there should be a way to attach an artifact to a project without requiring the project helper? --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
