On May 9, 2012, at 3:23 PM, Olivier Lamy wrote: > 2012/5/9 Jason van Zyl <ja...@tesla.io>: >> The only thing I might suggest is that you create a hybrid scanner that can >> deal with the old and new. It looks like you've already looked at [1], but >> the hybrid scanner is here[2]. > Thanks but this mix scanning is already implemented in the branch.
In one gleaner? I didn't see that, where's that? > Currently the only missing part is the help generation. We probably > need to think differently than a java source generation from the > plugin descriptor. Agreed. Generating source is not a good idea. Generate a descriptor with detailed information that can be parsed and utilized by other systems. Tool tips in IDEs could benefit from this descriptor for showing users how to use a plugin. >> >> The only thing I would like to sync up on is a couple changes I want to make >> to the plugin manager to make sure the current plugin packaging, the plugin >> packaging you're making and the plugin packaging I'm working on in Tesla all >> work together without conflicting. Anyone should theoretically be able to >> make a toolchain and allow users to take advantage of whatever they wish, >> this wouldn't work right now but I'll prepare the necessary patches for >> review. I am trying to create a more holistic approach to plugins for >> incremental processing, seamless integration in m2eclipse (write a plugin >> using the Tesla Plugin API and no need for a configurator), in the Tesla >> Shell and non-Maven tools. >> >> I'll ping you when you're closer to being done and we can work on the plugin >> manger changes together. >> >> [1]: https://github.com/etesla/tesla-plugin-api >> [2]: >> https://github.com/etesla/tesla-plugin-api/tree/master/tesla-plugin-tools-api/src/main/java/org/sonatype/maven/plugin/tools/java5/gleaner >> >> On May 9, 2012, at 11:56 AM, Olivier Lamy wrote: >> >>> Hi, >>> So I have pushed some stuff on supporting plugin descriptor generation >>> from annotations as described here [1]. >>> I have added support of having annotations from parent classes even if >>> they are not in the same project (from reactors and/or dependencies). >>> BTW we still need to do some javadoc parsing for @deprecated, @since >>> and comments for class/field description. So if annotations comes from >>> reactor module (easy to scan sources) but if comes from a dependency I >>> try to get the sources from the artifact with try to resolve the same >>> artifact with classifier sources. >>> >>> All is in the branch [2]. Note version bump to 3.0-SNAPSHOT. >>> As the scanning tru asm must be done on compiled classes an extra >>> configuration is needed: >>> >>> <plugin> >>> <groupId>org.apache.maven.plugins</groupId> >>> <artifactId>maven-plugin-plugin</artifactId> >>> <version>3.0-SNAPSHOT</version> >>> <configuration> >>> <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound> >>> </configuration> >>> <executions> >>> <execution> >>> <id>mojo-descriptor</id> >>> <phase>process-classes</phase> >>> <goals> >>> <goal>descriptor</goal> >>> </goals> >>> </execution> >>> </executions> >>> </plugin> >>> >>> You can have a look at the its >>> http://svn.apache.org/repos/asf/maven/plugin-tools/branches/MPLUGIN-189/maven-plugin-plugin/src/it/annotation* >>> >>> I still have an issue to fix for help generation. Currently the help >>> java mojo source is generated too early in the lifecycle so the plugin >>> descriptor from annotations is not yet available. >>> I will probably rewrite the help stuff to have a generic classes which >>> simply read the plugin descriptor file so need to have the plugin >>> descriptor available. >>> >>> Comments welcome :-) >>> >>> Thanks, >>> -- >>> Olivier Lamy >>> Talend: http://coders.talend.com >>> http://twitter.com/olamy | http://linkedin.com/in/olamy >>> >>> [1] >>> https://cwiki.apache.org/confluence/display/MAVEN/Java+5+Annotations+for+Plugins >>> [2] http://svn.apache.org/repos/asf/maven/plugin-tools/branches/MPLUGIN-189/ >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >> >> Thanks, >> >> Jason >> >> ---------------------------------------------------------- >> Jason van Zyl >> Founder, Apache Maven >> http://twitter.com/jvanzyl >> --------------------------------------------------------- >> >> happiness is like a butterfly: the more you chase it, the more it will >> elude you, but if you turn your attention to other things, it will come >> and sit softly on your shoulder ... >> >> -- Thoreau >> >> >> >> > > > > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl --------------------------------------------------------- What matters is not ideas, but the people who have them. Good people can fix bad ideas, but good ideas can't save bad people. -- Paul Graham
