Just an update. Everything is happy again:

https://builds.apache.org/view/M-R/view/Maven/job/core-integration-testing-maven-3-jdk-1.6/182/console

I worked with Ceki to push out another version of SLF4J Simple which allows the 
customization of the WARN label. In our case, the ITs we have specifically look 
for "WARNING" so a property was added to SLF4J Simple and I updated our 
configuration.

Ceki made some sample plugins and we'll post something tomorrow about some 
options for integration. Basically Merged vs Mixed: do we want to funnel 
everything into the the core logging backend, or let the plugin completely 
decided by declaring both the API and implementation. The outcome of this 
discussion will determine how to export (or not) packages from the core.

I will also look at the transfer listener. I funneled the events into the 
logging mechanism but for a console build I can detach the download events from 
the logging system when run on the console so the output isn't ugly, but in 
batch mode you probably want the download info captured so maybe there it 
should still be funneled into the logging backend.

Anyway, that's the update.

On Oct 11, 2012, at 4:44 PM, Jason van Zyl <ja...@tesla.io> wrote:

> 
> On Oct 11, 2012, at 4:26 PM, ceki <c...@qos.ch> wrote:
> 
>> Hello all,
>> 
>> I've created a trivial plugin which uses slf4j for logging:
>> 
>> https://github.com/ceki/foo-plugin
>> 
>> It declares a dependency on slf4j-api and slf4j-jdk14
>> 
>> Here are my observations:
>> 
>> 1) when running with maven 3.0.3 the slf4j declaration is honored,
>> i.e. logging goes through jul (slf4j-jdk14)
>> 
>> 2) when running with maven 3.1-SNAPSHOT, the foo-plugins dependency
>> declaration on slf4j-api and binding are simply ignored. Everything
>> goes to slf4j-simple (the binding used by Maven)
>> 
> 
> This is expected right now with the configuration of the realms currently 
> there.
> 
>> 
>> I find this second result quite surprising. Apparently, this is
>> because Maven 3.1-SNAPSHOT exports the slf4j packages overriding the
>> plugin dependency declarations on slf4j.
>> 
>> In both scenarios, no exceptions are thrown.
>> 
>> You are welcome to conduct your own tests.
>> 
> 
> I think the path forward is probably one of being explicit. 
> 
> If you have a simple plugin with no real components or much integration then 
> relying on the Mojo.getLog() method will likely suffice.
> 
> If you want to specifically use SLF4J then we should probably tell people 
> they have to specify the API JAR and the implementation JAR. Basically if you 
> use it, you know you're using it. I can retract the export of the SLF4J 
> packages from the core. Otherwise we get into magic of trying to detect 
> whether an implementation is specified or not, and provide one from the core 
> if it's not provided and that's just too magical in my opinion. I don't think 
> it's that onerous if you choose to use SLF4J you make both dependency 
> declarations on the API and implementation.
> 
> Thoughts?
> 
>> Best regards,
>> 
>> -- 
>> Ceki
>> 65% of statistics are made up on the spot
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>> 
> 
> Thanks,
> 
> Jason
> 
> ----------------------------------------------------------
> Jason van Zyl
> Founder & CTO, Sonatype
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
> 
> Our achievements speak for themselves. What we have to keep track
> of are our failures, discouragements and doubts. We tend to forget
> the past difficulties, the many false starts, and the painful
> groping. We see our past achievements as the end result of a
> clean forward thrust, and our present difficulties as
> signs of decline and decay.
> 
> -- Eric Hoffer, Reflections on the Human Condition
> 
> 
> 
> 
> 

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder & CTO, Sonatype
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------






Reply via email to