I'll see if Robert wants to fix the DOAP file and I'll respin tomorrow after he's commented.
On May 28, 2013, at 7:17 PM, Stephen Connolly <stephen.alan.conno...@gmail.com> wrote: > Yep.... looks fine to me. If you want to respin now, from _my_ PoV *should* > be no issues now... of course who knows what will crop up with the next > review ;-) > > > On 29 May 2013 00:07, Jason van Zyl <ja...@tesla.io> wrote: > >> This should suffice for the notice: >> >> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commitdiff;h=b0a83f62 >> >> On May 28, 2013, at 5:48 PM, Stephen Connolly < >> stephen.alan.conno...@gmail.com> wrote: >> >>> From my PoV the only outstanding issue is that the NOTICE.txt does not >>> reflect the fact that it is now Eclipse Aether and no longer Sonatype >>> Aether. >>> >>> I am unclear what the exact wording that is required, I am hoping that >>> somebody else can correct the file. All the license header issues are, to >>> my mind, fixed on master and Robert has switched over to >> package-info.java. >>> >>> I'll let Robert comment as to whether he sees the DOAP as a blocker. >>> >>> >>> On 28 May 2013 22:08, Jason van Zyl <ja...@tesla.io> wrote: >>> >>>> It's very easy to cut another release. If all the fixes are in that the >>>> PMC wishes it takes minutes to roll the release again. >>>> >>>> On May 28, 2013, at 4:43 PM, Robert Scholte <rfscho...@apache.org> >> wrote: >>>> >>>>> Some additional remarks: >>>>> - The copyright doesn't include current year (I've already fixed that >> on >>>> the trunk) >>>>> - doap:generate fails: The generated DOAP doesn't respect ASF rules. >>>>> >>>>> Just to be sure I understand correctly: these alpha-versions will never >>>> be released. They are created so users can try them. -1 votes would >> mean it >>>> is not yet ready for a beta or final release. Is this right? >>>>> >>>>> Robert >>>>> >>>>> Op Tue, 28 May 2013 10:38:07 +0200 schreef Stephen Connolly < >>>> stephen.alan.conno...@gmail.com>: >>>>> >>>>>> [x] Builds from source bundle >>>>>> [x] Builds some complex projects >>>>>> [x] Contains correct LICENSE.txt >>>>>> [ ] NOTICE.txt correctly attributes 3rd party components (See >>>> observation 1) >>>>>> [?] All source files, where appropriate, contain the ASL header (See >>>>>> observation 2) >>>>>> [?] Binary archives bundled within the source distribution (See >>>> observation >>>>>> 3) >>>>>> >>>>>> On the basis of the NOTICE.txt not acknowledging Eclipse Aether, and >>>> only >>>>>> on that basis I will be voting >>>>>> >>>>>> -0.99999 (binding) >>>>>> >>>>>> The other issues are non-critical but it would be nice to tidy them >>>> up... >>>>>> nice to have. >>>>>> >>>>>> Observations >>>>>> >>>>>> 1. No attribution of Eclipse Aether, only referenced as developed by >>>>>> Sonatype. >>>>>> >>>>>> 2. The following 39 files are missing license headers: >>>>>> >>>>>> apache-maven/src/bin/m2.conf >>>>>> apache-maven/src/conf/logging/simplelogger.properties >>>>>> >>>>>> >>>> >> maven-aether-provider/src/main/java/org/apache/maven/repository/internal/package.html >>>>>> maven-aether-provider/src/site/apt/index.apt >>>>>> maven-artifact/src/site/apt/index.apt >>>>>> maven-compat/compatibility.cfl >>>>>> maven-compat/src/main/resources/META-INF/maven/plugin.xml >>>>>> maven-core/lifecycle-executor.txt >>>>>> maven-core/plugin-manager.txt >>>>>> maven-core/project-builder.txt >>>>>> >>>> maven-core/src/main/resources/org/apache/maven/messages/build.properties >>>>>> maven-core/src/site/apt/artifact-handlers.apt >>>>>> maven-core/src/site/apt/configuration-management.apt >>>>>> maven-core/src/site/apt/default-bindings.apt.vm >>>>>> maven-core/src/site/apt/getting-to-container-configured-mojos.apt >>>>>> maven-core/src/site/apt/index.apt >>>>>> maven-core/src/site/apt/inheritance.apt >>>>>> maven-core/src/site/apt/lifecycles.apt.vm >>>>>> maven-core/src/site/apt/offline-mode.apt >>>>>> maven-core/src/site/apt/plugin-execution-isolation.apt >>>>>> maven-core/src/site/apt/scripting-support/marmalade-support.apt >>>>>> maven-core/src/site/resources/design/2.1-lifecycle-refactor.graffle >>>>>> >>>>>> >>>> >> maven-embedder/src/examples/simple-project/src/main/java/org/apache/maven/embedder/App.java >>>>>> >>>>>> >>>> >> maven-embedder/src/examples/simple-project/src/test/java/org/apache/maven/embedder/AppTest.java >>>>>> maven-embedder/src/main/resources/META-INF/MANIFEST.MF >>>>>> >>>>>> >>>> >> maven-embedder/src/main/resources/META-INF/maven/slf4j-configuration.properties >>>>>> maven-embedder/src/site/apt/cli.apt.vm >>>>>> maven-embedder/src/site/apt/index.apt.vm >>>>>> maven-embedder/src/site/apt/logging.apt >>>>>> maven-model-builder/src/site/apt/index.apt >>>>>> maven-model-builder/src/site/apt/super-pom.apt.vm >>>>>> maven-model/src/main/java/org/apache/maven/model/io/xpp3/package.html >>>>>> maven-model/src/main/java/org/apache/maven/model/merge/package.html >>>>>> maven-model/src/main/java/org/apache/maven/model/package.html >>>>>> maven-model/src/site/apt/index.apt >>>>>> maven-plugin-api/src/site/apt/index.apt >>>>>> maven-repository-metadata/src/site/apt/index.apt >>>>>> maven-settings/src/site/apt/index.apt >>>>>> README.bootstrap.txt >>>>>> >>>>>> None of these are actual production code, so I don't see this as a >>>> blocker >>>>>> for release, but it would be good to tidy them up. Additionally, the >>>>>> embedder examples should have their license explicitly stated to >> remove >>>>>> confusion for anyone pegging the examples to build their own code >> upon. >>>>>> >>>>>> In addition I note that there are 432 test resources that do not have >> a >>>>>> license header, however, as test resources it is legitimate to argue >>>> that >>>>>> the license header could affect the test. It would be good if we could >>>> get >>>>>> that number reduced, but only if we are confident that we are not >>>>>> introducing false test passes in the process. >>>>>> >>>>>> 3. There is one (non-test) archive bundled within the distribution: >>>>>> >>>>>> maven-ant-tasks-2.1.1.jar >>>>>> >>>>>> Given that this specific artifact suffers from the bootstrap issue >>>> (i.e. it >>>>>> needs Maven to build it) and the source is available and this artifact >>>> is >>>>>> not part of the built code, but rather the build process, I am unclear >>>> as >>>>>> to what the legal requirement for including this in the source >>>>>> distribution. It would be nice if we had some clarity on the artifact. >>>> OTOH >>>>>> it is code under the ASL and the NOTICE.txt perhaps covers it. >>>>>> >>>>>> >>>>>> On 25 May 2013 13:51, Jason van Zyl <ja...@tesla.io> wrote: >>>>>> >>>>>>> Here are the release bits for 3.1.0-alpha-1: >>>>>>> >>>>>>> Release notes: >>>>>>> >>>>>>> >>>> >> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=18967 >>>>>>> >>>>>>> Staging repository: >>>>>>> https://repository.apache.org/content/repositories/maven-044/ >>>>>>> >>>>>>> Staged distribution: >>>>>>> >>>>>>> >>>> >> https://repository.apache.org/content/repositories/maven-044/org/apache/maven/apache-maven/3.1.0-alpha-1/ >>>>>>> >>>>>>> Staged Site: >>>>>>> http://maven.apache.org/ref/3.1.0-alpha-1 >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Jason >>>>>>> >>>>>>> ---------------------------------------------------------- >>>>>>> Jason van Zyl >>>>>>> Founder & CTO, Sonatype >>>>>>> Founder, Apache Maven >>>>>>> http://twitter.com/jvanzyl >>>>>>> --------------------------------------------------------- >>>>>>> >>>>>>> We know what we are, but know not what we may be. >>>>>>> >>>>>>> -- Shakespeare >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>>>> >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>> >>>> >>>> Thanks, >>>> >>>> Jason >>>> >>>> ---------------------------------------------------------- >>>> Jason van Zyl >>>> Founder & CTO, Sonatype >>>> Founder, Apache Maven >>>> http://twitter.com/jvanzyl >>>> --------------------------------------------------------- >>>> >>>> We all have problems. How we deal with them is a measure of our worth. >>>> >>>> -- Unknown >>>> >>>> >>>> >>>> >>>> >>>> >> >> Thanks, >> >> Jason >> >> ---------------------------------------------------------- >> Jason van Zyl >> Founder & CTO, Sonatype >> Founder, Apache Maven >> http://twitter.com/jvanzyl >> --------------------------------------------------------- >> >> happiness is like a butterfly: the more you chase it, the more it will >> elude you, but if you turn your attention to other things, it will come >> and sit softly on your shoulder ... >> >> -- Thoreau >> >> >> >> >> >> Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder & CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl --------------------------------------------------------- happiness is like a butterfly: the more you chase it, the more it will elude you, but if you turn your attention to other things, it will come and sit softly on your shoulder ... -- Thoreau
