On Monday, 1 July 2013, Baptiste MATHUS wrote: > Guys, even if not convinced this is really useful, > I suppose voting template could just be adjusted so that the sha1 > or svn revision be added in the VOTE thread, and then get back to code as > usual?
+1 > > As it is just a 5 seconds additional operation to be done by the RM, I > think this is acceptable if this helps close this thread isn't it? > > My 2 cents. > > Cheers > > > 2013/7/1 Fred Cooke <fred.co...@gmail.com <javascript:;>> > > > Deleting and recreating a Git tag once published is an *extremely* stupid > > thing to do, at least an order of magnitude more so than the same action > in > > SVN. I sincerely hope that developers in this community would not engage > > in such activities. > > > > Nevertheless, this thread isn't about that, it's about providing a > specific > > and reliable way to know what we're supposed to be looking at. It's > about a > > line or two in an email, nothing more. If that is too much to ask, then > > something is seriously wrong here. > > > > On Mon, Jul 1, 2013 at 3:46 PM, Daniel Kulp <dk...@apache.org<javascript:;>> > wrote: > > > > > > > > +1 - I agree with Chris. > > > > > > Besides, if something DOES change in the svn/git tag, we get an email > > > notification so we can immediately figure out what's going on. In > > > addition, if you compare what you are voting on to whatever is the > latest > > > version of the the tag, if there is any difference whatsoever in the > > code, > > > the reviewer should immediately figure out why. I really don't care > > > about the exact revision number at all. Whatever is the latest "tag" > > > (head/whatever) is what's important as that's what will be held there > > > forever once the vote passes. > > > > > > Dan > > > > > > > > > On Jul 1, 2013, at 2:18 AM, Chris Graham > > > <chrisgw...@gmail.com<javascript:;>> > wrote: > > > > On Mon, Jul 1, 2013 at 4:20 AM, sebb <seb...@gmail.com<javascript:;>> > wrote: > > > > Reminder: all this thread is just about is adding the following lines > > > >> to vote e-mails: > > > >> > > > >> SVN Tag: > > > >> > > > >> > > > > > > https://svn.apache.org/repos/asf/maven/plugins/tags/maven-javadoc-plugin-2.9.1/ > > > >> (r1496317< > > > > > > https://svn.apache.org/repos/asf/maven/plugins/tags/maven-javadoc-plugin-2.9.1/(r1496317 > > > > > > > >> ) > > > >> > > > >> > > > > I still find this redundant. Given that the tag will not change for > the > > > > time window of the vote, and that the tag has it's own revision no, > and > > > you > > > > can derive the revision from the tag, so I see no need to quote the > > > > revision no. > > > > > > > > In the event of a failed vote, the version/tag will be reused and it > > will > > > > have a new revision, which also will be derivable. > > > > > > > > In the event of a successful vote, the tag will remain permanently. > > > > > > > > Should anyone ever wish to trawl through the (svn) history, then you > > will > > > > still be able to see the intermediate/failed votes and history. And > > you'd > > > > also need the archives of this list to address why the vote failed > etc. > > > > > > > > or whatever the equivalent is for Git (or any other SCM that may be > in > > > >> use at the time). > > > >> > > > >> Yes, others wil have their own requirements. > > > > > > -- > > > Daniel Kulp > > > dk...@apache.org <javascript:;> - http://dankulp.com/blog > > > Talend Community Coder - http://coders.talend.com > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org<javascript:;> > > > For additional commands, e-mail: dev-h...@maven.apache.org<javascript:;> > > > > > > > > > > > > -- > Baptiste <Batmat> MATHUS - http://batmat.net > Sauvez un arbre, > Mangez un castor ! > -- Sent from my phone
