> On July 8, 2013, 11:29 p.m., Ben Mahler wrote: > > Can you attach a screenshot for this one? And what happens with the other > > slave_*.html pages? > > Ross Allen wrote: > I added pre- and post-commit screenshots. The other slave_*.html pages > are unaffected.
Right, this looks good, but now the other slave_*.html pages do _not_ have the SlaveID breadcrumb, can you add it to the other slave_*.html pages as well? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12284/#review22870 ----------------------------------------------------------- On July 9, 2013, 7:19 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12284/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 7:19 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Ending crumb was the host, but it should be the ID of the slave. > > > Diffs > ----- > > src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d > > Diff: https://reviews.apache.org/r/12284/diff/ > > > Testing > ------- > > Rendered the "/slaves/:id" route to confirm page renders as expected. > > > File Attachments > ---------------- > > Before commit, no ID > > https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png > After commit, slave ID > > https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png > > > Thanks, > > Ross Allen > >
