> On July 9, 2013, 10:13 p.m., Ben Mahler wrote: > > Ship It!
Thanks Ross! I trust you've tested out the other pages? If so, I'll go ahead and get this committed for you! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12284/#review22935 ----------------------------------------------------------- On July 9, 2013, 7:18 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12284/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 7:18 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > The slave was represented by its host, but a slave is uniquely identified by > its ID not by its host. > > > Diffs > ----- > > src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d > src/webui/master/static/slave_executor.html > cf3d9567c701f074ba2b1e50467d3fddd3ed5014 > src/webui/master/static/slave_framework.html > 1a38c65c6febeece1a84716951b82066faa9b8be > > Diff: https://reviews.apache.org/r/12284/diff/ > > > Testing > ------- > > Rendered the "/slaves/:id" route to confirm page renders as expected. > > > File Attachments > ---------------- > > Before commit, no ID > > https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png > After commit, slave ID > > https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png > > > Thanks, > > Ross Allen > >
