----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12603/#review23230 -----------------------------------------------------------
src/sched/sched.cpp <https://reviews.apache.org/r/12603/#comment47118> CACHED_UPDATES_CAPACITY? Also, maybe add a note that this only works for smaller clusters. If there are more than 100 offers in 10 seconds, this will not eliminate any duplicates and will only be adding unnecessary overhead, right? Caching O(20-30) seconds of updates seems nicer, but we'd have to be careful of the memory / performance overhead. Thoughts? - Ben Mahler On July 17, 2013, 1:34 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12603/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 1:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-551 > https://issues.apache.org/jira/browse/MESOS-551 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/sched/sched.cpp 7ea82e547c612159c9fa24fb6d62e3d2b5f11982 > src/tests/status_update_manager_tests.cpp > 42395324dfe49659bee2229c6573ffef0874d923 > > Diff: https://reviews.apache.org/r/12603/diff/ > > > Testing > ------- > > make check (OSX and Linux) > > > Thanks, > > Vinod Kone > >
