> On July 17, 2013, 5:46 a.m., Bill Farner wrote: > > src/sched/sched.cpp, line 739 > > <https://reviews.apache.org/r/12603/diff/2/?file=322317#file322317line739> > > > > Consider dropping the hash set if it results in less code and risk of > > data drift bugs. O(n) is probably unnoticeable for n=100.
I've bumped this to 10,000. So I will leave the hash set optimization, since we would be doing this work for every update. > On July 17, 2013, 5:46 a.m., Bill Farner wrote: > > src/sched/sched.cpp, line 735 > > <https://reviews.apache.org/r/12603/diff/2/?file=322317#file322317line735> > > > > s/are/were/ done > On July 17, 2013, 5:46 a.m., Bill Farner wrote: > > src/sched/sched.cpp, line 738 > > <https://reviews.apache.org/r/12603/diff/2/?file=322317#file322317line738> > > > > More informative variable names would be nice, perhaps > > ackedUpdateUuidQueue, ackedUpdateUuids. Not sure if there's a preference > > for conciseness, if so that may dictate. we definitely prefer conciseness. i could just call them 'acks' but i thought that was a bit misleading too. thoughts? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12603/#review23241 ----------------------------------------------------------- On July 17, 2013, 1:34 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12603/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 1:34 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-551 > https://issues.apache.org/jira/browse/MESOS-551 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/sched/sched.cpp 7ea82e547c612159c9fa24fb6d62e3d2b5f11982 > src/tests/status_update_manager_tests.cpp > 42395324dfe49659bee2229c6573ffef0874d923 > > Diff: https://reviews.apache.org/r/12603/diff/ > > > Testing > ------- > > make check (OSX and Linux) > > > Thanks, > > Vinod Kone > >
