----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14438/#review26588 -----------------------------------------------------------
Ship it! src/master/master.hpp <https://reviews.apache.org/r/14438/#comment51833> what if framework_id itself is not present in the tasks map? Would this still work? src/master/master.hpp <https://reviews.apache.org/r/14438/#comment51834> ditto. - Vinod Kone On Oct. 2, 2013, 12:38 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14438/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 12:38 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Small cleanup, no functional change here. This changes the Slave::tasks: > > hashmap<std::pair<FrameworkID, TaskID>, Task*> tasks; // Before. > > hashmap<FrameworkID, hashmap<TaskID, Task*> > tasks; // After. > > > Diffs > ----- > > src/master/master.hpp bd5cb1ff05967518d7dc7f3a9dc0d32c22eb9643 > src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a > > Diff: https://reviews.apache.org/r/14438/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
