----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15161/#review27982 -----------------------------------------------------------
src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54433> How about cout << "Framework registered with " << frameworkId; src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54434> ditto. src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54435> How about cout << "Received status update" << status.state() << " for task" << status.task_id(); Then you don't need the switch statement. You also probably need to include "common/type_utils.hpp". src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54432> You could use protobuf::isTerminalUpdate(). src/cli/execute.cpp <https://reviews.apache.org/r/15161/#comment54436> Don't need to store the frameworkId. Just print it in (re-)registered. - Vinod Kone On Oct. 31, 2013, 11:33 p.m., Shingo Omura wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15161/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 11:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/cli/execute.cpp ac2f299 > > Diff: https://reviews.apache.org/r/15161/diff/ > > > Testing > ------- > > tested on my laptop, single host deployment. > $ bin/mesos-execute --master=127.0.0.1:5050 --name=echo --command="echo hello" > I1031 16:22:54.955093 163721216 sched.cpp:220] No credentials provided. > Attempting to register without authentication > The mesos-execute scheduler is registered. (framework id= > 201310311448-16777343-5050-23990-0007) > Your task is running. (framework-id=201310311448-16777343-5050-23990-0007, > task-id=echo) > Your task is finished. (framework-id=201310311448-16777343-5050-23990-0007, > task-id=echo) > > > Thanks, > > Shingo Omura > >
