> On Nov. 1, 2013, 12:43 a.m., Shingo Omura wrote: > > src/cli/execute.cpp, lines 131-132 > > <https://reviews.apache.org/r/15161/diff/1/?file=375904#file375904line131> > > > > OK.
You can just reply to the comment instead of making your comments as issues :) Look for "Add comment" link at the right bottom of every issue or comment you get from a reviewer. > On Nov. 1, 2013, 12:43 a.m., Shingo Omura wrote: > > src/cli/execute.cpp, lines 138-139 > > <https://reviews.apache.org/r/15161/diff/1/?file=375904#file375904line138> > > > > frameworkID isn't passed to reregistered(), is it? > > How could we know its frameworkID when re-registered without storing > > the information to scheduler. You are right. FrameworkID is not passed in re-registered. Maybe you can just say "Framework re-registered" without printing the id? I will leave it up to you. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15161/#review27986 ----------------------------------------------------------- On Oct. 31, 2013, 11:33 p.m., Shingo Omura wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15161/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 11:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/cli/execute.cpp ac2f299 > > Diff: https://reviews.apache.org/r/15161/diff/ > > > Testing > ------- > > tested on my laptop, single host deployment. > $ bin/mesos-execute --master=127.0.0.1:5050 --name=echo --command="echo hello" > I1031 16:22:54.955093 163721216 sched.cpp:220] No credentials provided. > Attempting to register without authentication > The mesos-execute scheduler is registered. (framework id= > 201310311448-16777343-5050-23990-0007) > Your task is running. (framework-id=201310311448-16777343-5050-23990-0007, > task-id=echo) > Your task is finished. (framework-id=201310311448-16777343-5050-23990-0007, > task-id=echo) > > > Thanks, > > Shingo Omura > >
