----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16332/#review30590 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/16332/#comment58591> s/none1/none/ 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/16332/#comment58593> newline, can you call this 'one' and just use an Option<int>::some(1) inline where you need another 1? 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/16332/#comment58594> newline 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/16332/#comment58595> Call this 'three'? - Ben Mahler On Dec. 18, 2013, 12:29 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16332/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 12:29 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Used in a future patch to compare "UPID from" with "Option<UPID> master". > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp > f12c0cafad141fe8857fbc14624ce43e3de77171 > 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp > bda06104f30d7358e0f8829e62e5363954355658 > > Diff: https://reviews.apache.org/r/16332/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
