> On Dec. 18, 2013, 1:13 a.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp, lines 88-89
> > <https://reviews.apache.org/r/16332/diff/3/?file=399067#file399067line88>
> >
> >     Any need for the 1 suffix on these?

I guess not :)


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16332/#review30591
-----------------------------------------------------------


On Dec. 18, 2013, 1:08 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16332/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2013, 1:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Used in a future patch to compare "UPID from" with "Option<UPID> master".
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> f12c0cafad141fe8857fbc14624ce43e3de77171 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 
> bda06104f30d7358e0f8829e62e5363954355658 
> 
> Diff: https://reviews.apache.org/r/16332/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to