----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16149/#review30683 -----------------------------------------------------------
As with my previous (and rather short) review - this is also a few issues that breaks compilation. Will follow up with style review as well here. src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment58774> Should this be LinuxForker? src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment58776> Is there a missing comma at the end of this line? src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment58779> There is some parentheses / bracket mismatch here; Should it be: 'static_cast<void*>(const_cast<lambda::function<int()>* >(&child)))) == -1) {' instead ? src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment58791> Should this be 'static int _call(void* child)'? src/slave/container/launcher.hpp <https://reviews.apache.org/r/16149/#comment58775> How about using Bytes() from stout to generate your 8MB. Also, wouldn't it be the right way to pick that number up from the system? src/slave/container/launcher.cpp <https://reviews.apache.org/r/16149/#comment58780> Does not match previous _child signature. src/slave/container/launcher.cpp <https://reviews.apache.org/r/16149/#comment58794> Doesn't match signature, should be: execute(const std::string& command, const std::string& directory, const Option<std::map<std::string, std::string> >& env, const Option<std::string>& user) src/slave/container/launcher.cpp <https://reviews.apache.org/r/16149/#comment58795> s/_//g - Niklas Nielsen On Dec. 19, 2013, 8:01 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16149/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2013, 8:01 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Launcher interface and MesosLauncher to support MesosContainerizers. > > Launchers handle the lifecycle of the executor process (and descendants). > > > Diffs > ----- > > src/Makefile.am 42dafbcd6e2d4f67d2705c5a2bea6ec6a0f4fcc1 > src/slave/container/launcher.hpp PRE-CREATION > src/slave/container/launcher.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16149/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
