> On Jan. 22, 2014, 3:47 a.m., Niklas Nielsen wrote: > > src/slave/container/launcher.hpp, line 124 > > <https://reviews.apache.org/r/16149/diff/6/?file=425486#file425486line124> > > > > Can you make this const?
This code has been removed. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16149/#review32450 ----------------------------------------------------------- On Jan. 21, 2014, 7:34 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16149/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 7:34 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Launcher interface and MesosLauncher to support MesosContainerizers. > > Launchers handle the lifecycle of the executor process (and descendants). > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/container/cgroups_launcher.hpp PRE-CREATION > src/slave/container/cgroups_launcher.cpp PRE-CREATION > src/slave/container/launcher.hpp PRE-CREATION > src/slave/container/launcher.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16149/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
