----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/#review32706 -----------------------------------------------------------
Ship it! src/launcher/executor.cpp <https://reviews.apache.org/r/17305/#comment61645> I think it makes sense to have a "global" reaper just like we do with statistics. Having multiple libprocess processes be delaying every 1 second to call waitpid is a bit wasteful. src/tests/environment.cpp <https://reviews.apache.org/r/17305/#comment61646> Why not LOG(FATAL) for these two? Or even FAIL()? - Benjamin Hindman On Jan. 24, 2014, 7:05 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17305/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 7:05 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Bugs: MESOS-943 > https://issues.apache.org/jira/browse/MESOS-943 > > > Repository: mesos-git > > > Description > ------- > > This removes the Mesos Reaper in preference of using the libprocess Reaper, > which no longer reaps non-monitored processes. > > > Diffs > ----- > > src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/slave/cgroups_isolator.hpp e86062e9abaaa263c32c55e9dbfefd700f605886 > src/slave/process_isolator.hpp 4ae093fe65775a2b9bec42071961dd58aa0c3d8b > src/slave/reaper.hpp 9a31c754475ecbce5299d8f18f38253c542404e5 > src/slave/reaper.cpp 5eabbc3911584cf47c353bcf4ca660c47c2c17be > src/tests/environment.cpp 6edce4552ef9a12b7b58cefea97ebacc9224ab04 > src/tests/reaper_tests.cpp 608ec0eff4eaae115d75621937a39b22e3bdb068 > src/tests/slave_recovery_tests.cpp 5a4c4fc4f687a37409d1afbda4c0d07fcdc3a4c7 > > Diff: https://reviews.apache.org/r/17305/diff/ > > > Testing > ------- > > make check > > I've also added an orphan check in the testing environment tear down. > > > Thanks, > > Ben Mahler > >
