> On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote:
> > src/launcher/executor.cpp, line 298
> > <https://reviews.apache.org/r/17305/diff/1/?file=447761#file447761line298>
> >
> > I think it makes sense to have a "global" reaper just like we do with
> > statistics. Having multiple libprocess processes be delaying every 1 second
> > to call waitpid is a bit wasteful.
That's true, at the same time we would be doing a 1 second no-op event loop on
all libprocess binaries, unless we added the ability to start/stop the Reaper.
I was thinking of a library-style API:
namespace process {
Future<Option<int> > reap(pid_t);
}
This would use a global Reaper under the hood, I'll be updating the diffs with
this cleaner interface.
> On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote:
> > src/tests/environment.cpp, line 248
> > <https://reviews.apache.org/r/17305/diff/1/?file=447766#file447766line248>
> >
> > Why not LOG(FATAL) for these two? Or even FAIL()?
I wanted to list all of the zombie processes, so I've updated this to now
FAIL() after the loop if zombies were present.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17305/#review32706
-----------------------------------------------------------
On Jan. 24, 2014, 7:05 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17305/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 7:05 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-943
> https://issues.apache.org/jira/browse/MESOS-943
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This removes the Mesos Reaper in preference of using the libprocess Reaper,
> which no longer reaps non-monitored processes.
>
>
> Diffs
> -----
>
> src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0
> src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d
> src/slave/cgroups_isolator.hpp e86062e9abaaa263c32c55e9dbfefd700f605886
> src/slave/process_isolator.hpp 4ae093fe65775a2b9bec42071961dd58aa0c3d8b
> src/slave/reaper.hpp 9a31c754475ecbce5299d8f18f38253c542404e5
> src/slave/reaper.cpp 5eabbc3911584cf47c353bcf4ca660c47c2c17be
> src/tests/environment.cpp 6edce4552ef9a12b7b58cefea97ebacc9224ab04
> src/tests/reaper_tests.cpp 608ec0eff4eaae115d75621937a39b22e3bdb068
> src/tests/slave_recovery_tests.cpp 5a4c4fc4f687a37409d1afbda4c0d07fcdc3a4c7
>
> Diff: https://reviews.apache.org/r/17305/diff/
>
>
> Testing
> -------
>
> make check
>
> I've also added an orphan check in the testing environment tear down.
>
>
> Thanks,
>
> Ben Mahler
>
>
