----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17338/ -----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone. Repository: mesos-git Description ------- - Without stringify the conditional operator converts “None” to an empty UPID and outputs @0.0.0.0:0 - Maybe it's worthwhile to make UPID's single-argument constructors explicit? Diffs ----- src/master/master.cpp c7d9186b9c22fb40b05aa6d5bc6f2d38fb7f73ea src/slave/slave.cpp 2d21e16a04d8f2419d8dee6c18664f1024bb8e73 Diff: https://reviews.apache.org/r/17338/diff/ Testing ------- make check Thanks, Jiang Yan Xu
