-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17338/
-----------------------------------------------------------

(Updated Jan. 30, 2014, 9:46 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
-------

Jie's


Repository: mesos-git


Description
-------

- Without stringify the conditional operator converts “None” to an empty UPID 
and outputs @0.0.0.0:0
- Maybe it's worthwhile to make UPID's single-argument constructors explicit?


Diffs (updated)
-----

  src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be 
  src/slave/slave.cpp a97b1d531d05e63e8ebaa474f526c110f5d573d4 

Diff: https://reviews.apache.org/r/17338/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu

Reply via email to