----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32751 -----------------------------------------------------------
3rdparty/libprocess/src/reaper.cpp <https://reviews.apache.org/r/17304/#comment61713> No, should've just been a comment. - Ian Downes On Jan. 24, 2014, 7:05 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17304/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 7:05 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Bugs: MESOS-943 > https://issues.apache.org/jira/browse/MESOS-943 > > > Repository: mesos-git > > > Description > ------- > > This is a copy of the Reaper from Mesos, with one key difference: This now > only reaps pids that were monitored explicitly. > > The test needed updating to reflect the fact that we can now retrieve the > exit status for an already exited process. > > This also opens up the opportunity to eliminate the 1 second delay in the > Reaper (using threads or SIGCHLD), but this is a copy of the Mesos Reaper for > now. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 40f01a7b3803696ccca440c8326e1d6d7c377459 > 3rdparty/libprocess/include/process/reaper.hpp PRE-CREATION > 3rdparty/libprocess/src/reaper.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/reaper_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17304/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
