-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17304/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 11:25 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
This now is exposed as a library utility, rather than a Reaper object:
Future<Option<int> > process::reap(pid_t);
Which uses a lazily initialized global reaper. This is more efficient, however,
the reap related tests take increasingly long when run in repetition due to the
Reaper's wait() loop getting scheduled further and further into the future
(more calls to Clock::advance / Clock::settle become necessary as the tests run
in repetition).
Bugs: MESOS-943
https://issues.apache.org/jira/browse/MESOS-943
Repository: mesos-git
Description
-------
This is a copy of the Reaper from Mesos, with one key difference: This now only
reaps pids that were monitored explicitly.
The test needed updating to reflect the fact that we can now retrieve the exit
status for an already exited process.
This also opens up the opportunity to eliminate the 1 second delay in the
Reaper (using threads or SIGCHLD), but this is a copy of the Mesos Reaper for
now.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 40f01a7b3803696ccca440c8326e1d6d7c377459
3rdparty/libprocess/include/process/reap.hpp PRE-CREATION
3rdparty/libprocess/src/reap.cpp PRE-CREATION
3rdparty/libprocess/src/tests/reap_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/17304/diff/
Testing
-------
make check
Thanks,
Ben Mahler
