----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/#review32952 -----------------------------------------------------------
Ship it! I hope the past vs present tense will be enough to not make the monotonic vs instantaneous stats confusing for those consuming this data. src/master/http.cpp <https://reviews.apache.org/r/17442/#comment62012> s/launched/active/ ? - Ben Mahler On Jan. 28, 2014, 2:59 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17442/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 2:59 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, David Robinson, and > Niklas Nielsen. > > > Bugs: MESOS-772 > https://issues.apache.org/jira/browse/MESOS-772 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > I opted for "active" tasks instead of "running" tasks because I didn't want > the stats endpoint to loop through all tasks to figure out if a task is in > RUNNING state. I think "active" is useful for most debugging purposes. > > > Diffs > ----- > > src/master/http.cpp 546e91dbb9c8ee1014bb4f0b3be2714ad6a2d520 > > Diff: https://reviews.apache.org/r/17442/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
