----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/#review32962 -----------------------------------------------------------
Ship it! src/master/http.cpp <https://reviews.apache.org/r/17442/#comment62039> s/launched_tasks/launched_tasks_gauge/ ? (or active_tasks_gauge, please yourself) All the other *_tasks are counters, which, but calling this something_tasks also implies it is. This isn't a counter so it's better to explicitly call it something else, such as something_tasks_gauge. - David Robinson On Jan. 28, 2014, 2:59 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17442/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 2:59 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, David Robinson, and > Niklas Nielsen. > > > Bugs: MESOS-772 > https://issues.apache.org/jira/browse/MESOS-772 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > I opted for "active" tasks instead of "running" tasks because I didn't want > the stats endpoint to loop through all tasks to figure out if a task is in > RUNNING state. I think "active" is useful for most debugging purposes. > > > Diffs > ----- > > src/master/http.cpp 546e91dbb9c8ee1014bb4f0b3be2714ad6a2d520 > > Diff: https://reviews.apache.org/r/17442/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
