-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review34721
-----------------------------------------------------------



src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment64950>

    How about?
    
    JSON::Object& role = roles[resource.role()];
    
    and inside the switch
    
    role.values[resource.name()] = ...
    
    



src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment64951>

    s/roleName/name/


- Vinod Kone


On Feb. 18, 2014, 5:58 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 5:58 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-990
>     https://issues.apache.org/jira/browse/MESOS-990
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 
>   src/common/http.hpp PRE-CREATION 
>   src/common/http.cpp PRE-CREATION 
>   src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e 
>   src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 
> 
> Diff: https://reviews.apache.org/r/18144/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Reply via email to