> On Feb. 18, 2014, 10:39 a.m., Ben Mahler wrote: > > src/common/http.cpp, line 15 > > <https://reviews.apache.org/r/18144/diff/3/?file=496551#file496551line15> > > > > Can you add using clauses for map and string?
I can, though I'm not sure it adds much in the way of readability. I prefer to be clear when I'm using something from the STL instead of some local/project specific version. > On Feb. 18, 2014, 10:39 a.m., Ben Mahler wrote: > > src/common/http.cpp, lines 17-18 > > <https://reviews.apache.org/r/18144/diff/3/?file=496551#file496551line17> > > > > This appears to not be saving very much in terms of readability, what > > if we just directly use these below? > > > > case Value::SCALAR: > > roles[resource.role()].values[resource.name()] = > > resource.scalar().value(); > > I was hoping to avoid the many braces and wrapped line, but sure. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18144/#review34725 ----------------------------------------------------------- On Feb. 18, 2014, 11:41 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18144/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 11:41 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-990 > https://issues.apache.org/jira/browse/MESOS-990 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/common/http.hpp PRE-CREATION > src/common/http.cpp PRE-CREATION > src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e > src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 > > Diff: https://reviews.apache.org/r/18144/diff/ > > > Testing > ------- > > make check. > > ran master/slave and checked http://localhost:5050/master/state.json by eye. > > > Thanks, > > Dominic Hamon > >
