----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18252/#review34824 -----------------------------------------------------------
Ship it! Modulo comments. src/log/leveldb.cpp <https://reviews.apache.org/r/18252/#comment65186> You're updating first _before_ checking status.ok(), what are the consequences of that? src/log/leveldb.cpp <https://reviews.apache.org/r/18252/#comment65187> CHECK_SOME :) src/log/leveldb.cpp <https://reviews.apache.org/r/18252/#comment65188> And here you're updating first _only_ when status.ok(), seems ok but just want to confirm with you. - Ben Mahler On Feb. 19, 2014, 1:21 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18252/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 1:21 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1014 > https://issues.apache.org/jira/browse/MESOS-1014 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/leveldb.hpp 7eb51be > src/log/leveldb.cpp 7819963 > > Diff: https://reviews.apache.org/r/18252/diff/ > > > Testing > ------- > > make check > > Will follow up with more tests on logs with large index. > > > Thanks, > > Jie Yu > >
