> On Feb. 19, 2014, 2:41 a.m., Ben Mahler wrote: > > src/log/leveldb.cpp, lines 384-386 > > <https://reviews.apache.org/r/18252/diff/4/?file=497398#file497398line384> > > > > Why is this a TODO, isn't this ok? If it's not ok, what would we be > > doing differently?
I left a TODO here in case I forget this issue. It is OK because worse case we have a larger-than-necessary log for a period of time (till the next truncation happens). > On Feb. 19, 2014, 2:41 a.m., Ben Mahler wrote: > > src/log/leveldb.cpp, line 403 > > <https://reviews.apache.org/r/18252/diff/4/?file=497398#file497398line403> > > > > Should this be an Error or a CHECK? Looks more like a bogus call to > > persist than a consistency issue in LevelDBStorage, no? Yeah, this check is redundant (index > 0 imply first.get < action.truncate().to()). Removed. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18252/#review34834 ----------------------------------------------------------- On Feb. 19, 2014, 2:24 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18252/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 2:24 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1014 > https://issues.apache.org/jira/browse/MESOS-1014 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/leveldb.hpp 7eb51be > src/log/leveldb.cpp 7819963 > > Diff: https://reviews.apache.org/r/18252/diff/ > > > Testing > ------- > > make check > > Will follow up with more tests on logs with large index. > > > Thanks, > > Jie Yu > >
