----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18261/#review34850 -----------------------------------------------------------
Ship it! src/tests/log_tests.cpp <https://reviews.apache.org/r/18261/#comment65244> This is kind of testing two cases: (1) a truncation when the log is empty and (2) truncating the log when it has a lot of holes. What about having two tests to cover both of these cases to account for other implementations in the future? - Benjamin Hindman On Feb. 19, 2014, 6:29 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18261/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 6:29 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1014 > https://issues.apache.org/jira/browse/MESOS-1014 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 768c66a > src/log/leveldb.cpp 7819963 > src/tests/log_tests.cpp 7e6dbde > > Diff: https://reviews.apache.org/r/18261/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
